Security Fix: Spending limit usable by removed multisig members#173
Open
AdeshAtole wants to merge 1 commit intoSquads-Protocol:mainfrom
Open
Security Fix: Spending limit usable by removed multisig members#173AdeshAtole wants to merge 1 commit intoSquads-Protocol:mainfrom
AdeshAtole wants to merge 1 commit intoSquads-Protocol:mainfrom
Conversation
spending_limit_use only checked if the member was in the spending limit's own member list, not whether they were still an active multisig member. Removed members could retain vault drain access through previously-assigned spending limits. Added multisig.is_member() check to enforce current membership.
|
@AdeshAtole is attempting to deploy a commit to the squads Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Finding
[MEDIUM] Removed Multisig Members Retain Spending Limit Access
File:
programs/squads_multisig_program/src/instructions/spending_limit_use.rs:102Issue:
spending_limit_usevalidates that the caller is inspending_limit.membersbut does NOT verify they are still an active member of the multisig. When a member is removed from the multisig viaconfig_transaction_execute, their key remains in any previously-assigned spending limits.Attack:
Fix: Added
multisig.is_member(member.key()).is_some()check to enforce current multisig membership before allowing spending limit use.Found during a Solana security audit